Remove dependency on @storybook/storybook-deployer (#5144)

Azure · Sep 9, 2024 · a167bb5 · a167bb5
1 parent 31b6977
commit a167bb5
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 69 deletions.
diff --git a/.github/workflows/deploy-storybook.yml b/.github/workflows/deploy-storybook.yml
@@ -44,11 +44,20 @@ jobs:
       - name: Run Storybook tests
         run: rush test -o storybook
 
-      - name: Deploy Storybook
+      - name: Copy .env values
         # storybook requires the env vars to be in a .env file for access in the manager.ts
         run: |
           echo TELEMETRY_INSTRUMENTATION_KEY=${{ secrets.TELEMETRY_INSTRUMENTATION_KEY }} > .env
-          npm run deploy-storybook -- --ci
         working-directory: ./packages/storybook
         env:
           GH_TOKEN: ${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}
+
+      - name: Upload Storybook GH Pages Artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: ./packages/storybook/storybook-static
+
+      - name: Deploy to GitHub Pages
+        uses: actions/deploy-pages@v4
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/config/rush/variants/stable/pnpm-lock.yaml b/common/config/rush/variants/stable/pnpm-lock.yaml
diff --git a/packages/storybook/package.json b/packages/storybook/package.json
@@ -7,7 +7,6 @@
     "build:dev": "cross-env NODE_ENV=development node ./scripts/build.mjs",
     "clean": "",
     "start": "cross-env NODE_ENV=development node ./scripts/start.mjs",
-    "deploy-storybook": "node ./scripts/deploy.mjs",
     "test": "node ./scripts/test.mjs",
     "test:ci-coverage": "echo skip",
     "test:coverage": "rushx test --coverage --coverageReporters=lcov",
@@ -61,7 +60,6 @@
     "@storybook/manager-webpack5": "6.5.16",
     "@storybook/node-logger": "^6.5.14",
     "@storybook/react": "^6.5.14",
-    "@storybook/storybook-deployer": "^2.8.16",
     "@storybook/theming": "^6.5.14",
     "@testing-library/jest-dom": "^6.4.8",
     "@types/jest": "^29.5.11",

diff --git a/packages/storybook/scripts/deploy.mjs b/packages/storybook/scripts/deploy.mjs
diff --git a/packages/storybook8/package.json b/packages/storybook8/package.json
@@ -9,7 +9,6 @@
     "build:dev-s8": "cross-env NODE_ENV=development node ./scripts/build.mjs",
     "clean": "",
     "start": "cross-env NODE_ENV=development node ./scripts/start.mjs",
-    "deploy-storybook": "node ./scripts/deploy.mjs",
     "storybook": "storybook",
     "test": "echo Storybook 8 test via 'test-s8' target",
     "test-s8": "node ./scripts/test.mjs",
@@ -66,7 +65,6 @@
     "@storybook/preview-api": "^8.2.6",
     "@storybook/react": "^8.2.6",
     "@storybook/react-webpack5": "^8.2.6",
-    "@storybook/storybook-deployer": "^2.8.16",
     "@storybook/test-runner": "^0.17.0",
     "@storybook/theming": "^8.2.6",
     "@testing-library/jest-dom": "^6.4.8",

diff --git a/packages/storybook8/scripts/deploy.mjs b/packages/storybook8/scripts/deploy.mjs