Skip to content

Commit

Permalink
Updated Node versions for Web UI library (#5589)
Browse files Browse the repository at this point in the history
  • Loading branch information
vhuseinova-msft authored Jan 30, 2025
1 parent eb8b42e commit a35d281
Show file tree
Hide file tree
Showing 16 changed files with 34 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/alpha-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-api-view-feature-level.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
fetch-depth: 0
# Ensure node version is great enough
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
# Install dependencies
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-prerelease-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Make sure that Rush is installed in run
- name: Add rush to run
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-azure-webapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-feature-azure-webapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-release-azure-webapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-release-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Install dependencies
- name: Install rush
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stress-test-ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-api-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
# Try get node_modules from cache
- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/update-chat-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- id: get-matrix
run: echo "matrix=$(node ./common/scripts/workflow-read-matrix.mjs)" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -82,10 +82,10 @@ jobs:
run: |
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config user.name "github-actions[bot]"
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/update-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- id: get-matrix
run: echo "matrix=$(node ./common/scripts/workflow-read-matrix.mjs)" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -378,7 +378,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -474,7 +474,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -570,7 +570,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ betaTest.describe('FluentChatMessageComponent keyboard navigation tests', () =>

betaTest('User can navigate to message using keyboard', async ({ mount, page }) => {
const component = await mount(<FluentChatMessageComponent {...props} />);
const messageBody = component.getByTestId('chat-composite-message');
await messageBody.waitFor({ state: 'visible' });

await page.keyboard.press('Tab');
const messageBody = component.getByTestId('chat-composite-message');
await expect(messageBody).toBeVisible();
await expect(messageBody).toBeFocused();

// check that focus stays on the message and not moved anywhere after additional Enter key press
Expand Down

0 comments on commit a35d281

Please sign in to comment.