[Chat] Added Image Loading Placeholder to Chat Messages #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chat bundle size is increased❗.
|
CallWithChat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
jpeng-ms
commented
Dec 5, 2023
jpeng-ms
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
jpeng-ms
changed the title
jpeng-ms
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft and
PorterNan
jpeng-ms
requested review from
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
waynemo,
emlynmac,
JoshuaLai and
palatter
jpeng-ms
assigned JoshuaLai, vhuseinova-msft, Leah-Xia-Microsoft, JamesBurnside, PorterNan and emlynmac
packages/react-components/src/components/ChatMessage/ChatMessageComponentAsMessageBubble.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/styles/MessageThread.styles.ts
Outdated
Show resolved
Hide resolved
emlynmac
reviewed
Dec 6, 2023
There was a problem hiding this comment.
This looks like it has changed the default scrolling behaviour?
There was a problem hiding this comment.
i actually think the "after" is correct since it scrolls to the bottom? also i feel like there's might be a race condition when snapshot is taken (maybe rendering the placeholder caused a few ms delay so snapshot is now taken when thread is scrolled to button)
vhuseinova-msft
approved these changes
Dec 6, 2023
jimchou-dev
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding image placeholder for messages with inline images
Why
to improve UX
How Tested
check the storybook page:
Process & policy checklist
Is this a breaking change?
multiple image test
Dark Light Mode Testing:
dark-light-mode.mov
Success flow
sucess-flow.mov
Error flow
error-testing.mov