Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support joining an existing call in the CallComposite & CallWithChatComposite #5148

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Support joining an existing call in the CallComposite & CallWithChatComposite #5148

wants to merge 11 commits into from

Conversation

JamesBurnside
Copy link
Member

@JamesBurnside JamesBurnside commented Sep 10, 2024 •
edited
Loading

What

  • Update createAzureCommunicationCallAdapterFromClients and createAzureCommunicationCallWithChatAdapterFromClients to allow passing in a Call object instead of a locator
  • Recalculate isTeamsMeeting/isRoomsMeeting/isTeamsCall on the fly instead of only at contruction time

Why

Supports scenarios such as CallAutomation or IncomingCalls were a call could be created outside of the regular adapter flow.

How Tested

Verified in the Call sample and CallWithChat sample that I could join existing calls. Tried joining with&without unMute and cameraOn

image

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-zvgezvnolt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zcowodfvcy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26920 / 43514
61.86%		 26920 / 43514
61.86%		 735 / 1355
54.24%		 2155 / 3473
62.05%
Current 26980 / 43523
61.99%		 26980 / 43523
61.99%		 735 / 1355
54.24%		 2184 / 3496
62.47%
Diff 60 / 9
0.13%		 60 / 9
0.13%		 0 / 0
0%		 29 / 23
0.42%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54661 / 90432
60.44%		 54661 / 90432
60.44%		 1107 / 2574
43%		 3237 / 5390
60.05%
Current 54776 / 90527
60.5%		 54776 / 90527
60.5%		 1113 / 2578
43.17%		 3247 / 5404
60.08%
Diff 115 / 95
0.06%		 115 / 95
0.06%		 6 / 4
0.17%		 10 / 14
0.03%

@JamesBurnside JamesBurnside marked this pull request as ready for review September 10, 2024 15:03
@JamesBurnside JamesBurnside requested review from a team as code owners September 10, 2024 15:03
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-tjfanrwuei.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-omnvhqdafb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-qbazpwoaft.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rnntycexrp.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-goydmmwkmg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ofgeoknwca.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1762309
  • Base size: 1762308
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ssoojffjbd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesBurnside @dmceachernmsft @edwardlee-msft