New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate bug bash tests involving dominant speakers, pinning, and spotlight #5173

Merged

mgamis-msft merged 29 commits into main from mgamis/automate-bug-bash-tests-phase-1

Dec 3, 2024

Contributor

mgamis-msft commented Sep 12, 2024 •

edited

Loading

What

Add playwright tests to replace bug bash tests we do for releases

CallWithChat bug bash tests

Group call

Become the dominant speaker in a call with video on
Become the dominant speaker in a call with only audio on
Pin the participant from participant list, video tile should be pinned for the participant
Pin the participant from participant list, participant item should be pinned
Pin 4 participants from participant limit, try pinning 5th participant, pinning should be disabled
Pin the participant from video tile, participant item should be pinned for the participant
Unpin participant from video tile, participant item should be unpinned for the participant
Unpin participant from participant item, video tile should be unpinned for the participant

Calling bug bash tests

Group call

Pin the participant from participant list, video tile should be pinned for the participant
Pin the participant from participant list, participant item should be pinned
Pin 4 participants from participant limit, try pinning 5th participant, pinning should be disabled
Pin the participant from video tile, participant item should be pinned for the participant
Unpin participant from video tile, participant item should be unpinned for the participant
Unpin participant from participant item, video tile should be unpinned for the participant

Interop call

Pin the participant from participant list, video tile should be pinned for the participant
Pin the participant from participant list, participant item should be pinned
Pin 4 participants from participant limit, try pinning 5th participant, pinning should be disabled
Pin the participant from video tile, participant item should be pinned for the participant
Unpin participant from video tile, participant item should be unpinned for the participant
Unpin participant from participant item, video tile should be unpinned for the participant

Why

We can focus more on doing tests that are harder to automate during bug bashes

How Tested

Verified added playwright tests passed

Process & policy checklist

I have updated the project documentation to reflect my changes if necessary.
I have read the CONTRIBUTING documentation.

Is this a breaking change?

This change causes current functionality to break.

mgamis-msft added 4 commits

September 12, 2024 20:33


          Automate dominant speaker, pinning, and spotlight tests

8dccbd1


          changelogs

1ca459e


          lint fix

59737eb


          lint fix

14b6270

mgamis-msft requested review from a team as code owners

September 12, 2024 20:47

mgamis-msft requested review from JamesBurnside, alkwa-msft, dmceachernmsft, carocao-msft, edwardlee-msft, PorterNan, prabhjot-msft, jimchou-dev, vhuseinova-msft, Leah-Xia-Microsoft, jpeng-ms, waynemo, emlynmac, JoshuaLai and palatter

September 12, 2024 20:47

mgamis-msft assigned edwardlee-msft and dmceachernmsft

Contributor

github-actions bot commented Sep 12, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment

Contributor

github-actions bot commented Sep 12, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Sep 12, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-qvymhpkzjt.chromatic.com/

Contributor

github-actions bot commented Sep 12, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment

Contributor

github-actions bot commented Sep 12, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ivididotts.chromatic.com/

mgamis-msft force-pushed the mgamis/automate-bug-bash-tests-phase-1 branch from 9cfbb24 to 7c71720 Compare

December 3, 2024 07:12

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-elhbubulpb.chromatic.com/

mgamis-msft force-pushed the mgamis/automate-bug-bash-tests-phase-1 branch from 7c71720 to a2eb561 Compare

December 3, 2024 07:24

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-evducdwzaw.chromatic.com/


          lint fixes

c2a3c94

mgamis-msft force-pushed the mgamis/automate-bug-bash-tests-phase-1 branch from a2eb561 to c2a3c94 Compare

December 3, 2024 07:35

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jcjofzrwhb.chromatic.com/


          Merge branch 'main' into mgamis/automate-bug-bash-tests-phase-1

b1f955b

mgamis-msft added the update_snapshots label

github-actions bot removed the update_snapshots label


          Update packages/react-components browser test snapshots

3bb8667

mgamis-msft enabled auto-merge (squash)

December 3, 2024 07:52

Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uapqpoquuj.chromatic.com/

mgamis-msft added the update_snapshots label

github-actions bot removed the update_snapshots label

github-actions bot added 3 commits

December 3, 2024 19:34


          Update packages/react-components browser test snapshots

4b1000c


          Update packages/react-components browser test snapshots

dc9e631


          Merge branch 'mgamis/automate-bug-bash-tests-phase-1' of https://gith…

2fe7bd3

…ub.com/Azure/communication-ui-library into mgamis/automate-bug-bash-tests-phase-1

Contributor

github-actions bot commented Dec 3, 2024

Chat bundle size is decreased✅.

Current size: 1762267
Base size: 1762268
Diff size: -1

Contributor

github-actions bot commented Dec 3, 2024

CallWithChat bundle size is not changed.

Current size: 11767078
Base size: 11767078
Diff size: 0

Contributor

github-actions bot commented Dec 3, 2024

Calling bundle size is not changed.

Current size: 11767065
Base size: 11767065
Diff size: 0

mgamis-msft merged commit a4f3225 into main

40 of 41 checks passed

mgamis-msft deleted the mgamis/automate-bug-bash-tests-phase-1 branch

December 3, 2024 20:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

edwardlee-msft edwardlee-msft approved these changes

dmceachernmsft dmceachernmsft approved these changes

JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Labels

None yet