Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Update Eslint to the latest version 9 #5222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carocao-msft
Copy link
Contributor

What

Update Eslint to the latest version 9

Guides

Use the following command to convert the current eslint files to the new flat config file
npx @eslint/migrate-config .eslintrc.json
Run rushx lint to identify errors
https://eslint.org/docs/latest/use/configure/migration-guide

Known Issue

Stuk/eslint-plugin-header#57
Header/header rules no longer supported
We can look into prettier for this issue

Random CI failure related to prettier
prettier/eslint-plugin-prettier#671 (comment)

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1756438
  • Base size: 1756438
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11750179
  • Base size: 11750179
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant