Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breakout rooms page to storybook #5274

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgamis-msft
Copy link
Contributor

What

Add breakout rooms page to storybook

Why

Provide Contoso documentation on breakout rooms available in beta. Also, give component-only customers like Modality guidance on how to add breakout rooms to their application

How Tested

Ran storybook 8 locally and ensured text and links work

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@@ -0,0 +1,135 @@
import { Meta, Source } from '@storybook/addon-docs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, we have (as of 10 minutes ago) fully moved to storybook 8!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Removed.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Copy link
Contributor

github-actions bot commented Oct 7, 2024

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Chat bundle size is not changed.

  • Current size: 1756461
  • Base size: 1756461
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Copy link
Contributor

github-actions bot commented Oct 7, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26686 / 42905
62.19%
26686 / 42905
62.19%
729 / 1329
54.85%
2116 / 3384
62.52%
Current 26623 / 42905
62.05%
26623 / 42905
62.05%
729 / 1329
54.85%
2116 / 3378
62.64%
Diff -63 / 0
-0.14%
-63 / 0
-0.14%
0 / 0
0%
0 / -6
0.12%

Copy link
Contributor

github-actions bot commented Oct 7, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54071 / 88319
61.22%
54071 / 88319
61.22%
1096 / 2485
44.1%
3174 / 5259
60.35%
Current 54094 / 88319
61.24%
54094 / 88319
61.24%
1096 / 2485
44.1%
3209 / 5281
60.76%
Diff 23 / 0
0.02%
23 / 0
0.02%
0 / 0
0%
35 / 22
0.41%

mgamis-msft added a commit that referenced this pull request Oct 7, 2024
* Add breakout rooms page to storybook

* Remove breakout rooms from storybook 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants