Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Features Stream Util Implementation and Call client state for Together mode feature #5362

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Call Features Stream Util Implementation and Call client state for Together mode feature #5362

merged 13 commits into from
Nov 5, 2024

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Oct 25, 2024 •
edited
Loading

What

This PR contains

  • Logic to support call features stream view create and dispose
  • Together Mode State onclient

Why

This is part work needed to integrate together mode in web UI

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@cn0151 cn0151 changed the title Change files Call Features Stream Util Implementation and Call client state for Together mode feature Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gixdrpahga.chromatic.com/

@cn0151 cn0151 marked this pull request as ready for review October 25, 2024 17:55
@cn0151 cn0151 requested review from a team as code owners October 25, 2024 17:55
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nogtxprjup.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zknygjvuiq.chromatic.com/

dmceachernmsft
dmceachernmsft reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@dmceachernmsft dmceachernmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get CI to clear and lets get this in! looks great!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bnfpdbitpf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ksnygdvftc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ijnznzxfjd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uyffluiqji.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pmehxckphg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53905 / 88580
60.85%		 53905 / 88580
60.85%		 1100 / 2492
44.14%		 3210 / 5331
60.21%
Current 54191 / 89344
60.65%		 54191 / 89344
60.65%		 1101 / 2519
43.7%		 3211 / 5334
60.19%
Diff 286 / 764
-0.2%		 286 / 764
-0.2%		 1 / 27
-0.44%		 1 / 3
-0.02%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26926 / 43351
62.11%		 26926 / 43351
62.11%		 733 / 1346
54.45%		 2138 / 3433
62.27%
Current 26926 / 43350
62.11%		 26926 / 43350
62.11%		 733 / 1348
54.37%		 2161 / 3447
62.69%
Diff 0 / -1
0%		 0 / -1
0%		 0 / 2
-0.08%		 23 / 14
0.42%

@cn0151 cn0151 enabled auto-merge (squash) November 5, 2024 18:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Chat bundle size is not changed.

  • Current size: 1758914
  • Base size: 1758914
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Calling bundle size is not changed.

  • Current size: 8139366
  • Base size: 8139366
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kvowedkkrb.chromatic.com/

@cn0151 cn0151 merged commit 639e504 into main Nov 5, 2024
41 checks passed
@cn0151 cn0151 deleted the cnwankwo/CallFeatureStream branch November 5, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft left review comments

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cn0151 @JamesBurnside @dmceachernmsft @edwardlee-msft