Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] dialpad logic updates #5454

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Bugfix] dialpad logic updates #5454

wants to merge 17 commits into from

Conversation

dmceachernmsft
Copy link
Member

What

Introduces new API for controlling the dialpad page appearence

Why

allows for more granular control over the dialer page

https://skype.visualstudio.com/SPOOL/_workitems/edit/3840579

How Tested

Validated locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners November 29, 2024 22:24
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kcnreqpvha.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dgdjkwfqct.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 55377 / 90344
61.29%		 55377 / 90344
61.29%		 1147 / 2589
44.3%		 3387 / 5554
60.98%
Current 55426 / 90378
61.32%		 55426 / 90378
61.32%		 1147 / 2589
44.3%		 3439 / 5585
61.57%
Diff 49 / 34
0.03%		 49 / 34
0.03%		 0 / 0
0%		 52 / 31
0.59%

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Dec 2, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ijkdliarme.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wwrnbdirun.chromatic.com/

@dmceachernmsft dmceachernmsft added update_snapshots Set this label to request automated update of UI snapshots breaking-change and removed update_snapshots Set this label to request automated update of UI snapshots labels Dec 4, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Chat bundle size is increased❗.

  • Current size: 1762268
  • Base size: 1762267
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dxbhhceakx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gsamnwchyn.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside JamesBurnside left review comments

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@JamesBurnside JamesBurnside

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmceachernmsft @JamesBurnside @edwardlee-msft @mgamis-msft