Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablize Caption Banner component #5460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

carocao-msft
Copy link
Contributor

What

Captions Banner Component change from internal component to public component

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Chat bundle size is increased❗.

  • Current size: 1762337
  • Base size: 1762268
  • Diff size: 69

Copy link
Contributor

github-actions bot commented Dec 3, 2024

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Dec 3, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27513 / 43432
63.34%
27513 / 43432
63.34%
771 / 1368
56.35%
2340 / 3651
64.09%
Current 27459 / 43473
63.16%
27459 / 43473
63.16%
771 / 1368
56.35%
2334 / 3642
64.08%
Diff -54 / 41
-0.18%
-54 / 41
-0.18%
0 / 0
0%
-6 / -9
-0.01%

Copy link
Contributor

github-actions bot commented Dec 3, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 55404 / 90343
61.32%
55404 / 90343
61.32%
1147 / 2589
44.3%
3425 / 5573
61.45%
Current 55410 / 90378
61.3%
55410 / 90378
61.3%
1147 / 2589
44.3%
3406 / 5565
61.2%
Diff 6 / 35
-0.02%
6 / 35
-0.02%
0 / 0
0%
-19 / -8
-0.25%

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants