Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hermetic tests for Media access (hard mute) feature #5531

Merged
merged 25 commits into from
Jan 9, 2025
Merged

Add hermetic tests for Media access (hard mute) feature #5531

merged 25 commits into from
Jan 9, 2025

Conversation

fuyan2024
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@fuyan2024 fuyan2024 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 5, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gvjnwpdmih.chromatic.com/

@fuyan2024 fuyan2024 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 5, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ndapppflwz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27807 / 44245
62.84%		 27807 / 44245
62.84%		 780 / 1418
55%		 2330 / 3678
63.34%
Current 27869 / 44264
62.96%		 27869 / 44264
62.96%		 780 / 1418
55%		 2309 / 3670
62.91%
Diff 62 / 19
0.12%		 62 / 19
0.12%		 0 / 0
0%		 -21 / -8
-0.43%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56174 / 92227
60.9%		 56174 / 92227
60.9%		 1153 / 2655
43.42%		 3414 / 5656
60.36%
Current 56191 / 92263
60.9%		 56191 / 92263
60.9%		 1153 / 2655
43.42%		 3454 / 5684
60.76%
Diff 17 / 36
0%		 17 / 36
0%		 0 / 0
0%		 40 / 28
0.4%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qrwrnvbvvk.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mflatxsurw.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mednheemli.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yjfcnzfxxk.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@fuyan2024 fuyan2024 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 6, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 6, 2025
@fuyan2024 fuyan2024 changed the title Add hermetic test for hard mute Add hermetic tests for Media access (hard mute) feature Jan 6, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-likvfdkije.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bphceembna.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aqsmzzykvg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@fuyan2024 fuyan2024 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-shssqtcxjj.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@fuyan2024 fuyan2024 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dmxhqsaisr.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ystbgvxffl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Chat bundle size is not changed.

@fuyan2024 fuyan2024 merged commit 175381b into main Jan 9, 2025
42 checks passed
@fuyan2024 fuyan2024 deleted the fuyan/hard-mute-hermetic-test branch January 9, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@carocao-msft carocao-msft carocao-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@miguhern miguhern

@carocao-msft carocao-msft

@fuyan2024 fuyan2024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuyan2024 @mgamis-msft @carocao-msft @miguhern