Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated together mode CC #5558

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Updated together mode CC #5558

merged 2 commits into from
Jan 17, 2025

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 14, 2025

What

Included conditional compile for together mode logic

Why

Needed to ensure together mode logic doesn't get into stable releases

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@cn0151 cn0151 marked this pull request as ready for review January 14, 2025 18:43
@cn0151 cn0151 requested review from a team as code owners January 14, 2025 18:43
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uippefjtzp.chromatic.com/

@carocao-msft carocao-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1769574
  • Base size: 1769573
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bzrgmeqbxa.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27905 / 44311
62.97%		 27905 / 44311
62.97%		 782 / 1423
54.95%		 2316 / 3695
62.67%
Current 27910 / 44311
62.98%		 27910 / 44311
62.98%		 782 / 1423
54.95%		 2336 / 3705
63.04%
Diff 5 / 0
0.01%		 5 / 0
0.01%		 0 / 0
0%		 20 / 10
0.37%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56747 / 93466
60.71%		 56747 / 93466
60.71%		 1156 / 2669
43.31%		 3481 / 5720
60.85%
Current 56713 / 93467
60.67%		 56713 / 93467
60.67%		 1156 / 2669
43.31%		 3450 / 5705
60.47%
Diff -34 / 1
-0.04%		 -34 / 1
-0.04%		 0 / 0
0%		 -31 / -15
-0.38%

@cn0151 cn0151 merged commit 6a438d3 into main Jan 17, 2025
59 of 88 checks passed
@cn0151 cn0151 deleted the cnwankwo/togethermode_cc_fix branch January 17, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carocao-msft carocao-msft carocao-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@dmceachernmsft dmceachernmsft

@carocao-msft carocao-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cn0151 @dmceachernmsft @carocao-msft