Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable together mode for mobile #5581

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Enable together mode for mobile #5581

wants to merge 12 commits into from
+203 −231

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 23, 2025

What

This PR contains changes that enables together mode on mobile. It also contains changes that enables together mode display names to be tabable

Why

Needed as part of together mode integration

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

cn0151 added 3 commits January 23, 2025 22:28
@cn0151
Enable together mode for mobile
cdc71a0 
Enabled together mode signaling divs to be tabable
@cn0151
Clean up
7511218
@cn0151
clean up
fafedbe
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-scsluwsted.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@cn0151 cn0151 marked this pull request as ready for review January 23, 2025 23:09
@cn0151 cn0151 requested review from a team as code owners January 23, 2025 23:09
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hppuqrppri.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nlrhozjrce.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dgdodtiigh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fbqpbvqkjx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

dmceachernmsft
dmceachernmsft approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@dmceachernmsft dmceachernmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is that the tabbing is not needed per A11y as @edwardlee-msft found out. I think the question is to remove it or not. approved otherwise

@cn0151 cn0151 added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 30, 2025
@cn0151 cn0151 enabled auto-merge (squash) January 30, 2025 20:43
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pfrjyjxiak.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-awwqsvngiy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27936 / 44345
62.99%		 27936 / 44345
62.99%		 783 / 1424
54.98%		 2345 / 3715
63.12%
Current 27878 / 44345
62.86%		 27878 / 44345
62.86%		 783 / 1424
54.98%		 2330 / 3704
62.9%
Diff -58 / 0
-0.13%		 -58 / 0
-0.13%		 0 / 0
0%		 -15 / -11
-0.22%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 57171 / 94356
60.59%		 57171 / 94356
60.59%		 1161 / 2687
43.2%		 3445 / 5718
60.24%
Current 57243 / 94328
60.68%		 57243 / 94328
60.68%		 1163 / 2689
43.25%		 3484 / 5747
60.62%
Diff 72 / -28
0.09%		 72 / -28
0.09%		 2 / 2
0.05%		 39 / 29
0.38%

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@cn0151 cn0151 added the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1776794
  • Base size: 1776794
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tznsfyagtg.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cn0151 @dmceachernmsft @edwardlee-msft