Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand button for mobile RTT and captions #5586

Merged
merged 12 commits into from
Jan 28, 2025

Conversation

carocao-msft
Copy link
Contributor

What

Screenshot 2025-01-28 at 9 55 45 AM

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
@carocao-msft carocao-msft requested review from a team as code owners January 28, 2025 18:25
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
Copy link
Contributor

Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jan 28, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27929 / 44340
62.98%
27929 / 44340
62.98%
783 / 1423
55.02%
2342 / 3712
63.09%
Current 27888 / 44341
62.89%
27888 / 44341
62.89%
783 / 1423
55.02%
2311 / 3702
62.42%
Diff -41 / 1
-0.09%
-41 / 1
-0.09%
0 / 0
0%
-31 / -10
-0.67%

Copy link
Contributor

github-actions bot commented Jan 28, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56843 / 93588
60.73%
56843 / 93588
60.73%
1158 / 2669
43.38%
3446 / 5714
60.3%
Current 56883 / 93717
60.69%
56883 / 93717
60.69%
1158 / 2669
43.38%
3448 / 5718
60.3%
Diff 40 / 129
-0.04%
40 / 129
-0.04%
0 / 0
0%
2 / 4
0%

Copy link
Contributor

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 28, 2025
Copy link
Contributor

@carocao-msft carocao-msft enabled auto-merge (squash) January 28, 2025 23:01
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1776683
  • Base size: 1775358
  • Diff size: 1325

@carocao-msft carocao-msft merged commit b0f2c1f into main Jan 28, 2025
41 checks passed
@carocao-msft carocao-msft deleted the carocao/RTTExpandMobile branch January 28, 2025 23:12
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants