Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove media access conditional compile - part 1 #5587

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Remove media access conditional compile - part 1 #5587

merged 10 commits into from
Jan 28, 2025

Conversation

fuyan2024
Copy link
Member

@fuyan2024 fuyan2024 commented Jan 28, 2025 •
edited
Loading

What

Part 1 PR to remove "media-access" conditional compile

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@fuyan2024 fuyan2024 marked this pull request as ready for review January 28, 2025 18:46
@fuyan2024 fuyan2024 requested review from a team as code owners January 28, 2025 18:46
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ydzbejkvvo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pxnfzqypbu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-txydfxhbze.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27874 / 44341
62.86%		 27874 / 44341
62.86%		 783 / 1423
55.02%		 2329 / 3699
62.96%
Current 27929 / 44346
62.97%		 27929 / 44346
62.97%		 783 / 1423
55.02%		 2322 / 3702
62.72%
Diff 55 / 5
0.11%		 55 / 5
0.11%		 0 / 0
0%		 -7 / 3
-0.24%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56820 / 93717
60.62%		 56820 / 93717
60.62%		 1158 / 2669
43.38%		 3469 / 5722
60.62%
Current 56785 / 93683
60.61%		 56785 / 93683
60.61%		 1158 / 2669
43.38%		 3485 / 5730
60.82%
Diff -35 / -34
-0.01%		 -35 / -34
-0.01%		 0 / 0
0%		 16 / 8
0.2%

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kuqgicyqrv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-thhkljbzhu.chromatic.com/

@fuyan2024 fuyan2024 enabled auto-merge (squash) January 28, 2025 23:00
@fuyan2024 fuyan2024 disabled auto-merge January 28, 2025 23:01
@fuyan2024 fuyan2024 enabled auto-merge (squash) January 28, 2025 23:01
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nawrxfaibh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1776683
  • Base size: 1776683
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wvzxnwqkyw.chromatic.com/

@fuyan2024 fuyan2024 merged commit 167e634 into main Jan 28, 2025
41 checks passed
@fuyan2024 fuyan2024 deleted the fuyan/remove-media-access-cc-1 branch January 28, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carocao-msft carocao-msft carocao-msft approved these changes

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@miguhern miguhern

@dmceachernmsft dmceachernmsft

@carocao-msft carocao-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fuyan2024 @mgamis-msft @carocao-msft @miguhern @dmceachernmsft