RTT Feature Storybook #5593
RTT Feature Storybook #5593
Conversation
carocao-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
|
||
| [RealTimeTextModal](./?path=/docs/components-real-time-text-modal--docs) is a component showing a disclaimer warning that real time text is enabled for everyone in the call once turned on. This is important as real time text can not be turned off once it is started. | ||
|
|
||
| [StartRealTimeTextButton](./?path=/docs/components-start-real-time-text-button--docs) is a component that can be used to turn on real time text. Note that Real-Time Text will not be started for everyone in the call until a message is sent. |
There was a problem hiding this comment.
how come Real-Time text here is spelt like this here but no where else?
There was a problem hiding this comment.
- correction, we use
real-time texthere and some other places. But we're mixing in a fewreal time textaround. Can we stick to justreal-time text
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uuqqjypbqq.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mksetruquf.chromatic.com/ |
|
|
||
| <SingleLineBetaBanner /> | ||
|
|
||
| Azure Communication Services UI Library is adding support for Real-Time Text. Real-Time Text is a powerful tool that enables developers to enhance the accessibility of their videos. |
There was a problem hiding this comment.
do we want to instead say "Azure Communication Services UI Library supports Real-Time text"
Just thinking this makes sense now as we are just adding it but the text here should read well in 6 months when this is in GA and common use.
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Chat bundle size is decreased✅.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ggkecttjkp.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
What
Moved internal stories out to be external.
Fixed a few bugs in StartRealTimeTextButton (onLabel --> label so the label displays when setting showLabel to true)
A few bugs in Captions Banner Component : auto scroll for RTT, placeholder for textfield, display content when caption is on but start captions in progress is false
Created new stories for:
Why
How Tested
Process & policy checklist
Is this a breaking change?