Cnwankwo/together mode ut #5597
Draft
+514
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-akqtlirurs.chromatic.com/ |
cn0151
changed the base branch from
main
to
cnwankwo/together_mode_bugbash_fixes
cn0151
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
and removed request for
a team
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-omfkpwltvn.chromatic.com/ |
|
|
||
| const updatedLocalParticipant = { | ||
| ...localParticipant, | ||
| reaction: { reactionType: '👍', receivedOn: new Date() } |
There was a problem hiding this comment.
To properly represent the reaction type this should be an enum 'like' | 'heart' and so on
| @@ -177,6 +176,7 @@ export const TogetherModeOverlay = memo( | |||
| participantStatus.id && ( | |||
| <div | |||
| key={participantStatus.id} | |||
| data-ui-group="together-mode-participant" | |||
There was a problem hiding this comment.
For our hermetic and unit tests we usually use data-ui-id unsure what the group is and how it would impact our existing selector fetching. if you want to reuse the utilities in the hermetic tests you will want to use this prop instead
cn0151
changed the base branch from
cnwankwo/together_mode_bugbash_fixes
to
main
cn0151
changed the base branch from
main
to
cnwankwo/together_mode_bugbash_fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Process & policy checklist
Is this a breaking change?