Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check capability to see if set caption language should be shown for teams meeting #5600

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Check capability to see if set caption language should be shown for teams meeting #5600

wants to merge 20 commits into from

Conversation

carocao-msft
Copy link
Contributor

What

Check capability to see if set caption language should be shown for teams meeting

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft requested review from a team as code owners January 30, 2025 21:38
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pjgwlmbmyd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ubdvierduv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dcybbaqqfy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27936 / 44345
62.99%		 27936 / 44345
62.99%		 783 / 1424
54.98%		 2345 / 3715
63.12%
Current 27882 / 44345
62.87%		 27882 / 44345
62.87%		 783 / 1424
54.98%		 2336 / 3704
63.06%
Diff -54 / 0
-0.12%		 -54 / 0
-0.12%		 0 / 0
0%		 -9 / -11
-0.06%

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 30, 2025
@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 30, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ldoahgsukm.chromatic.com/

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hykfhyczui.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-avnfaowhxe.chromatic.com/

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 1776793
  • Base size: 1776794
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ugegjzzwjh.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carocao-msft @mgamis-msft @edwardlee-msft