Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HMR causing codespace to not load samples correctly #5602

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Remove HMR causing codespace to not load samples correctly #5602

merged 3 commits into from
Jan 31, 2025

Conversation

edwardlee-msft
Copy link
Contributor

What

Undo PR #4567 as it's causing codespace to not load samples correctly.
Temporary fix while we try to understand this issue further.
Believe issue occurred after node and webpack update. Have not pinpointed exactly when yet. Will dive deeper into this when time allows. In the meantime this pr is to help unblock others using codespace.

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@edwardlee-msft edwardlee-msft requested review from a team as code owners January 30, 2025 23:15
@edwardlee-msft edwardlee-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 30, 2025
@edwardlee-msft edwardlee-msft changed the title Remove HRM causing codespace to not load samples correctly Remove HMR causing codespace to not load samples correctly Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27938 / 44345
63%		 27938 / 44345
63%		 783 / 1424
54.98%		 2333 / 3714
62.81%
Current 27883 / 44345
62.87%		 27883 / 44345
62.87%		 783 / 1424
54.98%		 2326 / 3700
62.86%
Diff -55 / 0
-0.13%		 -55 / 0
-0.13%		 0 / 0
0%		 -7 / -14
0.05%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 57118 / 94356
60.53%		 57118 / 94356
60.53%		 1161 / 2687
43.2%		 3436 / 5708
60.19%
Current 57194 / 94356
60.61%		 57194 / 94356
60.61%		 1161 / 2687
43.2%		 3466 / 5731
60.47%
Diff 76 / 0
0.08%		 76 / 0
0.08%		 0 / 0
0%		 30 / 23
0.28%

@edwardlee-msft edwardlee-msft enabled auto-merge (squash) January 30, 2025 23:32
@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1776794
  • Base size: 1776794
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@edwardlee-msft edwardlee-msft merged commit b2e9bd9 into main Jan 31, 2025
40 checks passed
@edwardlee-msft edwardlee-msft deleted the elee/remove-hmr-blocker branch January 31, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@carocao-msft carocao-msft carocao-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@carocao-msft carocao-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardlee-msft @mgamis-msft @carocao-msft