Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional compile for media access - Part 4 #5603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fuyan2024
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1776809
  • Base size: 1776809
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27930 / 44338
62.99%
27930 / 44338
62.99%
782 / 1423
54.95%
2320 / 3700
62.7%
Current 27937 / 44338
63%
27937 / 44338
63%
782 / 1423
54.95%
2357 / 3724
63.29%
Diff 7 / 0
0.01%
7 / 0
0.01%
0 / 0
0%
37 / 24
0.59%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56995 / 94182
60.51%
56995 / 94182
60.51%
1160 / 2686
43.18%
3476 / 5727
60.69%
Current 56913 / 93975
60.56%
56913 / 93975
60.56%
1160 / 2685
43.2%
3476 / 5734
60.62%
Diff -82 / -207
0.05%
-82 / -207
0.05%
0 / -1
0.02%
0 / 7
-0.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants