Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

together mode reference update #5605

Merged
merged 5 commits into from
Feb 3, 2025
Merged

together mode reference update #5605

merged 5 commits into from
Feb 3, 2025

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 31, 2025 •
edited
Loading

What

Update together mode feature's sdk references

Why

How Tested

Notification Stack:
image

VideoGallery
image

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-eubyexjlym.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lcnoehztfx.chromatic.com/

@edwardlee-msft
Copy link
Contributor

Looks good to me, feel free to put it out of draft mode

@cn0151 cn0151 marked this pull request as ready for review January 31, 2025 23:12
@cn0151 cn0151 requested review from a team as code owners January 31, 2025 23:12
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mnrkmphbyq.chromatic.com/

@cn0151 cn0151 added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Chat bundle size is not changed.

  • Current size: 1776975
  • Base size: 1776975
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-cbqshabrik.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27886 / 44338
62.89%		 27886 / 44338
62.89%		 782 / 1423
54.95%		 2328 / 3701
62.9%
Current 27932 / 44338
62.99%		 27932 / 44338
62.99%		 782 / 1423
54.95%		 2343 / 3713
63.1%
Diff 46 / 0
0.1%		 46 / 0
0.1%		 0 / 0
0%		 15 / 12
0.2%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56916 / 93964
60.57%		 56916 / 93964
60.57%		 1161 / 2687
43.2%		 3477 / 5733
60.64%
Current 56944 / 93990
60.58%		 56944 / 93990
60.58%		 1161 / 2687
43.2%		 3439 / 5711
60.21%
Diff 28 / 26
0.01%		 28 / 26
0.01%		 0 / 0
0%		 -38 / -22
-0.43%

@cn0151 cn0151 merged commit 0d02739 into main Feb 3, 2025
57 of 87 checks passed
@cn0151 cn0151 deleted the cnwankwo/update-together-mode-ref branch February 3, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cn0151 @edwardlee-msft @dmceachernmsft