Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved issue where toolbar wasn't focused when show editing options #5611

Merged
merged 10 commits into from
Feb 5, 2025
Merged

Resolved issue where toolbar wasn't focused when show editing options #5611

merged 10 commits into from
Feb 5, 2025

Conversation

palatter
Copy link
Member

@palatter palatter commented Feb 3, 2025

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@palatter palatter requested review from a team as code owners February 3, 2025 19:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qqakuwuagk.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 57044 / 94118
60.6%		 57044 / 94118
60.6%		 1161 / 2690
43.15%		 3500 / 5746
60.91%
Current 57004 / 94125
60.56%		 57004 / 94125
60.56%		 1161 / 2690
43.15%		 3446 / 5716
60.28%
Diff -40 / 7
-0.04%		 -40 / 7
-0.04%		 0 / 0
0%		 -54 / -30
-0.63%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27950 / 44655
62.59%		 27950 / 44655
62.59%		 786 / 1436
54.73%		 2307 / 3699
62.36%
Current 28001 / 44659
62.69%		 28001 / 44659
62.69%		 786 / 1436
54.73%		 2355 / 3724
63.23%
Diff 51 / 4
0.1%		 51 / 4
0.1%		 0 / 0
0%		 48 / 25
0.87%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mybxpjktkn.chromatic.com/

@palatter palatter force-pushed the palatter/fix-focus-editing-options branch from ac213ee to 34ff1cb Compare February 3, 2025 23:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ryibnqnbkn.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ogzqnzjudl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kjqujhrike.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mpduswfdsy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Chat bundle size is decreased✅.

  • Current size: 1777205
  • Base size: 1777206
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ncayouyiju.chromatic.com/

@palatter palatter merged commit bff4b77 into main Feb 5, 2025
57 of 89 checks passed
@palatter palatter deleted the palatter/fix-focus-editing-options branch February 5, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palatter @JoshuaLai @vhuseinova-msft