Refactor of outputs to simplify bicep deployments #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els to match public docs
ryanhamel
reviewed
Oct 10, 2024
| @@ -327,13 +322,18 @@ resource ccwVirtualNetwork 'Microsoft.Network/virtualNetworks@2023-11-01' = { | |||
| } | |||
| } | |||
|
|
|||
| var peeringEnabled = contains(network,'vnetToPeer') | |||
| var peeredVnetId = network.?vnetToPeer.?id ?? 'q/w/e/r/t/y/u/i/o' | |||
There was a problem hiding this comment.
Try using an approved fake resource id for these instead.
see https://review.learn.microsoft.com/en-us/help/platform/reference-sensitive-identifier?branch=main
ryanhamel
reviewed
Oct 10, 2024
| @@ -78,13 +78,15 @@ var subnets = create_new_vnet | |||
| additional: { id: join([network.?id, 'subnets', network.?additionalFilerSubnet ?? 'null'], '/') } | |||
| } | |||
|
|
|||
| var existingNetworkId = network.?id ?? 'q/w/e/r/t/y/u/i/o' | |||
There was a problem hiding this comment.
Use an approved resourceId
https://review.learn.microsoft.com/en-us/help/platform/reference-sensitive-identifier?branch=main
ryanhamel
reviewed
Oct 10, 2024
| @@ -413,9 +413,10 @@ var subnets = union( | |||
| create_database ? { database: subnet_database } : {} | |||
| ) | |||
|
|
|||
| var dbID = databaseConfig.?dbId ?? 'q/w/e/r/t/y/u/i/o' | |||
There was a problem hiding this comment.
Use an approved resourceId
https://review.learn.microsoft.com/en-us/help/platform/reference-sensitive-identifier?branch=main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant fields from the outputs section of the UI definition file to allow for easier bicep deployments for our DevOps and govcloud users. Also cleaned up some things in the UI to align with the reality of outputs (i.e., collecting excess information that would go unused).