Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get instance id for desired control-queue(s) #1069

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
90 changes: 90 additions & 0 deletions Test/DurableTask.AzureStorage.Tests/TestPartitionIndex.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
// ----------------------------------------------------------------------------------
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// ----------------------------------------------------------------------------------

namespace DurableTask.AzureStorage.Tests
{
using System.Collections.Generic;
using System.Threading;
using Microsoft.VisualStudio.TestTools.UnitTesting;

[TestClass]
public class TestPartitionIndex
{
private AzureStorageOrchestrationService azureStorageOrchestrationService;
private AzureStorageOrchestrationServiceSettings settings;
private int partitionCount = 4;
private CancellationTokenSource cancellationTokenSource;
private const string TaskHub = "taskHubName";

private Dictionary<uint, string> partitionToInstanceId = new Dictionary<uint, string>()
{
{ 0, "sampleinstanceid!13"},
{ 1, "sampleinstanceid!3"},
{ 2, "sampleinstanceid!11"},
{ 3, "sampleinstanceid!1"}
};

private Dictionary<uint, string> partitionToInstanceIdWithExplicitPartitionPlacement = new Dictionary<uint, string>()
{
{ 0, "sampleinstanceid!0"},
{ 1, "sampleinstanceid!1"},
{ 2, "sampleinstanceid!2"},
{ 3, "sampleinstanceid!3"}
};

[TestInitialize]
public void Initialize()
{
cancellationTokenSource = new CancellationTokenSource();

settings = new AzureStorageOrchestrationServiceSettings()
{
StorageConnectionString = TestHelpers.GetTestStorageAccountConnectionString(),
TaskHubName = TaskHub,
PartitionCount = partitionCount
};

azureStorageOrchestrationService = new AzureStorageOrchestrationService(settings);
}

[TestMethod]
public void GetPartitionIndexTest_EnableExplicitPartitionPlacement_False()
{
settings.EnableExplicitPartitionPlacement = false;

foreach (var kvp in partitionToInstanceId)
{
var instanceId = kvp.Value;
var expectedPartitionIndex = kvp.Key;
var partitionIndex = azureStorageOrchestrationService.GetPartitionIndex(instanceId);

Assert.AreEqual(expectedPartitionIndex, partitionIndex);
}
}

[TestMethod]
public void GetPartitionIndexTest_EnableExplicitPartitionPlacement_True()
{
settings.EnableExplicitPartitionPlacement = true;

foreach (var kvp in partitionToInstanceIdWithExplicitPartitionPlacement)
{
var instanceId = kvp.Value;
var expectedPartitionIndex = kvp.Key;
var partitionIndex = azureStorageOrchestrationService.GetPartitionIndex(instanceId);

Assert.AreEqual(expectedPartitionIndex, partitionIndex);
}
}
}
}
26 changes: 24 additions & 2 deletions src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2048,9 +2048,9 @@ public Task<string> DownloadBlobAsync(string blobUri)

// TODO: Change this to a sticky assignment so that partition count changes can
// be supported: https://github.com/Azure/azure-functions-durable-extension/issues/1
async Task<ControlQueue?> GetControlQueueAsync(string instanceId)
internal async Task<ControlQueue?> GetControlQueueAsync(string instanceId)
{
uint partitionIndex = Fnv1aHashHelper.ComputeHash(instanceId) % (uint)this.settings.PartitionCount;
uint partitionIndex = GetPartitionIndex(instanceId);
string queueName = GetControlQueueName(this.settings.TaskHubName, (int)partitionIndex);

ControlQueue cachedQueue;
Expand All @@ -2075,6 +2075,28 @@ public Task<string> DownloadBlobAsync(string blobUri)
return cachedQueue;
}

internal uint GetPartitionIndex(string instanceId)
{
uint totalPartitions = (uint)this.settings.PartitionCount;

int placementSeparatorPosition = instanceId.LastIndexOf('!');

// if the instance id ends with !nnn, where nnn is an unsigned number, it indicates explicit partition placement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test that documents the behavior if the customer uses an instanceID with multiple ! in there? Say instanceID "A!1!B!3` should probably map to partition "3", right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a test that checks that instanceID myinstanceID!NotANumber does not trigger any errors / that it correctly ignores the explicit placement logic.

if (
this.settings.EnableExplicitPartitionPlacement
&& placementSeparatorPosition != -1
&& uint.TryParse(instanceId.Substring(placementSeparatorPosition + 1), out uint index))
{
var partitionId = index % totalPartitions;
return (uint)partitionId;
Comment on lines +2092 to +2093
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this allows for the following scenario:
Assume we have 4 partitions,
And user creates instanceID "abc!7", they will still land on some queue, but it won't be the 7th queue, because that doesn't exist.

From first principles, I would think we'd want to error out in this case. But it seems this behavior is consistent with Netherite. I would prefer to throw in this case, but curious to know what others think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasaini-microsoft - now that I think about it, it may be a good idea to keep the behavior you implemented. If in the future, we make the partitionCount something that users can change 'on the fly' (not possible today, but I'm working to make this happen), then this behavior would be resilient to changes in the number of partitions.

Let's keep this behavior for now but let's also try to emit a warning for when the total number of partitions is less than the customer's specified target number. That will help notify the customer that something possibly unintuitive is taking place. Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually in favor of not generating a warning. The reason is that the warning would actually fire almost constantly in all the applications where I have used this.

The expected use is that applications want to distribute things over the queues but dont actually know or care how many queues there are (e.g. like partition keys in Azure Storage).

Copy link
Collaborator

@jviau jviau Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sebastianburckhardt - I feel this will be more noisy than helpful. I would only consider it if this leads to undefined behavior. But it isn't, it is by design hence the % operator. We need to make sure this behavior is well documented.

Copy link
Collaborator

@davidmrdavid davidmrdavid Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's ignore the warning, I'm convinced. Agreed on the need to document it. We can do that documentation in an azure-docs PR.

}
else
{
return Fnv1aHashHelper.ComputeHash(instanceId) % totalPartitions;

}
}

/// <summary>
/// Disposes of the current object.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,5 +318,11 @@ internal LogHelper Logger
/// Consumers that require separate dispatch (such as the new out-of-proc v2 SDKs) must set this to true.
/// </summary>
public bool UseSeparateQueueForEntityWorkItems { get; set; } = false;

/// <summary>
/// Whether to allow instanceIDs to use special syntax to land on a specific partition.
/// If enabled, when an instanceID ends with suffix '!nnn', where 'nnn' is an unsigned number, the instance will land on the partition/queue for to that number.
/// </summary>
public bool EnableExplicitPartitionPlacement { get; set; } = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to consider - it is not safe to change this from false to true (or vice-versa) while an orchestrator with the special syntax is in-flight. If we do that, any pre-existing messages for that orchestrator may now be considered to be "in the wrong queue".

Let's call this out in the intellisense

}
}
Loading