You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sample status YAML in the document is not properly indented, which may cause readability issues.
sample status:
```yamlstatus:
conditions:
- lastTransitionTime: "2025-04-29T02:57:33Z"message: | Invalid profile: GET https://management.azure.com/subscriptions/xxx/resourceGroups/your-fleet-atm-rg/providers/Microsoft.Network/trafficmanagerprofiles/fleet-34ec2e40-5cc4-4a30-8c09-4b787169cef0 -------------------------------------------------------------------------------- RESPONSE 403: 403 Forbidden ERROR CODE: AuthorizationFailed -------------------------------------------------------------------------------- { "error": { "code": "AuthorizationFailed", "message": "The client 'xxx' with object id 'xxx' does not have authorization to perform action 'Microsoft.Network/trafficmanagerprofiles/read' over scope '/subscriptions/xxx/resourceGroups/your-fleet-atm-rg/providers/Microsoft.Network/trafficmanagerprofiles/fleet-34ec2e40-5cc4-4a30-8c09-4b787169cef0' or the scope is invalid. If access was recently granted, please refresh your credentials." } }
The sample status YAML in the document is not properly indented, which may cause readability issues.
```yamlstatus:
conditions:
- lastTransitionTime: "2025-04-29T06:39:10Z"message: Domain name is not available. Please choose a different profile nameor namespaceobservedGeneration: 2reason: DNSNameNotAvailablestatus: "False"type: Programmed
</details>
<details><summary><a href='https://github.com/Azure/fleet-networking/pull/293/files#diff-29a8d18842958c88964cda2c80f9d979f84fd0792562c21193bb03904c1c5662R61-R70'><strong>Formatting Issue</strong></a>
The sample status YAML in the document is not properly indented, which may cause readability issues.
</summary>
```markdown
```yaml
status:
conditions:
- lastTransitionTime: "2025-04-29T06:43:57Z"
message: TrafficManagerProfile "invalid-profile" is not found
observedGeneration: 1
reason: Invalid
status: "False"
type: Accepted
</details>
<details><summary><a href='https://github.com/Azure/fleet-networking/pull/293/files#diff-29a8d18842958c88964cda2c80f9d979f84fd0792562c21193bb03904c1c5662R87-R95'><strong>Formatting Issue</strong></a>
The sample status YAML in the document is not properly indented, which may cause readability issues.
</summary>
```markdown
status:
conditions:
- lastTransitionTime: "2025-04-29T07:50:49Z"
message: ServiceImport "invalid-service" is not found
observedGeneration: 1
reason: Invalid
status: "False"
type: Accepted
</details>
<details><summary><a href='https://github.com/Azure/fleet-networking/pull/293/files#diff-29a8d18842958c88964cda2c80f9d979f84fd0792562c21193bb03904c1c5662R99-R109'><strong>Formatting Issue</strong></a>
The sample status YAML in the document is not properly indented, which may cause readability issues.
</summary>
```markdown
status:
conditions:
- lastTransitionTime: "2025-04-29T07:56:05Z"
message: '1 service(s) exported from clusters cannot be exposed as the Azure
Traffic Manager, for example, service exported from aks-member-5 is invalid:
unsupported service type "ClusterIP"'
observedGeneration: 1
reason: Invalid
status: "False"
type: Accepted
-- Ensure that the Azure traffic manager profile exists, which could be manually deleted by other users. To recover this profile, you need to delete the `TrafficManagerBackend` and re-create it.+- Ensure that the Azure traffic manager profile exists, which could be manually deleted by other users. Verify its existence in the Azure portal or using Azure CLI. To recover this profile, you need to delete the `TrafficManagerBackend` and re-create it.
Suggestion importance[1-10]: 6
__
Why: Adding a verification step enhances the troubleshooting process by providing clear actions for the user.
Low
Specify service type
Clarify that the service must be of type LoadBalancer.
-- Ensure that the exported `Service` is load balancer type and exposed via an Azure public IP address, which must have a DNS name assigned to be used in a Traffic Manager profile.+- Ensure that the exported `Service` is of type LoadBalancer and exposed via an Azure public IP address, which must have a DNS name assigned to be used in a Traffic Manager profile.
Suggestion importance[1-10]: 6
__
Why: Specifying the service type improves clarity and ensures users understand the requirement for a LoadBalancer service.
Low
Specify ceiling application
Clarify that the ceiling function is applied to the calculated weight.
-The weight of actual Azure Traffic Manager endpoint created for a single cluster is the ceiling value of a number computed as `trafficManagerBackend` weight/(sum of all `serviceExport` weights behind the `trafficManagerBackend`)+The weight of the actual Azure Traffic Manager endpoint created for a single cluster is the ceiling value of the number computed as `trafficManagerBackend` weight / (sum of all `serviceExport` weights behind the `trafficManagerBackend`).
Suggestion importance[1-10]: 5
__
Why: The suggestion clarifies the application of the ceiling function, improving readability but does not address a critical issue.
-Please check the `status` field of the `TrafficManagerProfile` or the `trafficmanagerprofile/controller.go` file in hub-net-controller-manager logs for more information.+Please check the `status` field of the `TrafficManagerProfile` or the `trafficmanagerprofile/controller.go` file in the hub-net-controller-manager pod logs for more information.
Suggestion importance[1-10]: 2
__
Why: The suggestion clarifies the location of the logs but offers only a minor improvement in user understanding. It does not address any critical issues or significantly enhance functionality.
-Please check the `status` field of the `TrafficManagerProfile` or the `trafficmanagerprofile/controller.go` file in hub-net-controller-manager logs for more information.+Please check the `status` field of the `TrafficManagerProfile` or the `trafficmanagerprofile/controller.go` logs in the hub-net-controller-manager for more information.
Suggestion importance[1-10]: 2
__
Why: The suggestion is correct but offers only a minor improvement in clarity. It does not significantly impact the functionality or correctness of the documentation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer