Add disable environment override option. #594
Merged
+116
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want to overwrite the provided arguments with possible settings from your environment variables.
This adds a flag to convert-kubeconfig for disabling environment override. It uses the flag in "kubelogin get-token" UpdateFromEnv() to return early and disregard possible setting of environment variables.
kubelogin convert-kubeconfig -l spn --client-id xxx --client-secret xxx --disable-environment-override
will result in:
Provides solution for #196