Adding an option to disable instance discovery in AcquirePoPTokenConfidential #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
bganapa
force-pushed
the
instancediscovery
branch
from
e5046f7 to
f06b959
Compare
JorgeDaboub
approved these changes
Jan 16, 2025
bganapa
commented
Jan 16, 2025
|
JorgeDaboub
approved these changes
Jan 22, 2025
|
LGTM |
weinong
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In autonomous (completely disconnected) environments to disable authority validation and instance discovery, msal provides an option with WithInstanceDiscovery(false) in the client creation.
The PR introduces a param instanceDiscovery in AcquirePoPTokenConfidential to disable instance discovery and calls WithInstanceDiscovery
The other code paths where AcquirePoPTokenConfidential is called , the default value of true is set. When AcquirePoPTokenConfidential is called from Client Side Proxy (arcproxy) , the value will be customized depending on whether the current cloud is autonomous (disconnected) or not