Azure/bastion #129
Open
Azure/bastion #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
1 task
zioproto
requested changes
Feb 7, 2025
| <!-- BEGIN_TF_DOCS --> | ||
| # Default example | ||
|
|
||
| This deploys the module with Azure Bastion. |
There was a problem hiding this comment.
neat: double space "module with"
|
|
||
| ```hcl | ||
| terraform { | ||
| required_version = ">= 1.3.0" |
There was a problem hiding this comment.
by AVM template this should be:
required_version = ">= 1.9, < 2.0"
| required_providers { | ||
| azurerm = { | ||
| source = "hashicorp/azurerm" | ||
| version = ">= 3.7.0, < 4.0.0" |
There was a problem hiding this comment.
Same here:
version = ">= 4, <5"
|
|
||
| ## Section to provide a random Azure region for the resource group | ||
| # This allows us to randomize the region for the resource group. | ||
| module "regions" { |
There was a problem hiding this comment.
Please use
module "regions" {
source = "Azure/avm-utl-regions/azurerm"
version = "0.3.0"
}
|
|
||
| # This is required for resource modules | ||
| resource "azurerm_resource_group" "this" { | ||
| location = "East US 2" # Hardcoded because we have to test in a region without availability zones |
There was a problem hiding this comment.
Is this true for this example ?
| # with a data source. | ||
| module "test" { | ||
| source = "../../" | ||
| kubernetes_version = "1.28" |
|
|
||
| module "avm_res_network_virtualnetwork" { | ||
| source = "Azure/avm-res-network-virtualnetwork/azurerm" | ||
| version = "0.2.3" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example with Bastion
closes #117