Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option of setting the user_assigned_identity_id name #157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nellyk
Copy link
Member

@nellyk nellyk commented Jan 17, 2025

Description

Closes #147

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • [ x ] Azure Verified Module updates:
    • [ x] Bugfix containing backwards compatible bug fixes
      • [ x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • [ x] I'm sure there are no other open Pull Requests for the same update/change
  • [ x] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [x ] I did run all pre-commit checks

@nellyk nellyk requested review from Copilot and zioproto January 17, 2025 14:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • main.tf: Language not supported
  • variables.tf: Language not supported
@kewalaka
Copy link

the variable is called id, description references an id, but it is setting a name?

I have proposed a broader mechanism to do this in #161

@nellyk
Copy link
Member Author

nellyk commented Jan 24, 2025

the variable is called id, description references an id, but it is setting a name?

I have proposed a broader mechanism to do this in #161

you're right ideally this should be a name and note reference an "id" i'll update the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: module consumers should be able to specify all naming conventions
2 participants