feat: rule names (#15)

* feat: modify rule names to be more predictable

* feat: make rule names generic

* test: fix integration

attrvalue/set_value.go

@@ -31,9 +31,9 @@ func NewSetRule[T cmp.Ordered](resourceType string, attributeName string, expect
 
 func (r *SetRule[T]) Name() string {
 	if r.nestedBlockType != nil {
-		return fmt.Sprintf("%s.%s.%s_must_be_%+v", r.resourceType, *r.nestedBlockType, r.attributeName, r.expectedValues)
+		return fmt.Sprintf("set_value_%s.%s.%s", r.resourceType, *r.nestedBlockType, r.attributeName)
 	}
-	return fmt.Sprintf("%s.%s_must_be_%v", r.resourceType, r.attributeName, r.expectedValues)
+	return fmt.Sprintf("set_value_%s.%s", r.resourceType, r.attributeName)
 }
 
 func (r *SetRule[T]) Check(runner tflint.Runner) error {

attrvalue/simple_value.go

@@ -43,9 +43,9 @@ func (r *SimpleRule[T]) Link() string {
 
 func (r *SimpleRule[T]) Name() string {
 	if r.nestedBlockType != nil {
-		return fmt.Sprintf("%s.%s.%s_must_be_%+v", r.resourceType, *r.nestedBlockType, r.attributeName, r.expectedValues)
+		return fmt.Sprintf("simple_value_%s.%s.%s", r.resourceType, *r.nestedBlockType, r.attributeName)
 	}
-	return fmt.Sprintf("%s.%s_must_be_%+v", r.resourceType, r.attributeName, r.expectedValues)
+	return fmt.Sprintf("simple_value_%s.%s", r.resourceType, r.attributeName)
 }
 
 func (r *SimpleRule[T]) Check(runner tflint.Runner) error {

attrvalue/unknown_value.go

@@ -42,9 +42,9 @@ func NewUnknownValueNestedBlockRule(resourceType, nestedBlockType, attributeName
 
 func (r *UnknownValueRule) Name() string {
 	if r.nestedBlockType != nil {
-		return fmt.Sprintf("%s.%s.%s_must_be_unknown", r.resourceType, *r.nestedBlockType, r.attributeName)
+		return fmt.Sprintf("unknown_value_%s.%s.%s", r.resourceType, *r.nestedBlockType, r.attributeName)
 	}
-	return fmt.Sprintf("%s.%s_must_be_unknown", r.resourceType, r.attributeName)
+	return fmt.Sprintf("unknown_value_%s.%s", r.resourceType, r.attributeName)
 }
 
 func (r *UnknownValueRule) Check(runner tflint.Runner) error {

integration/optional-defaults-incorrect/result.json

@@ -17,7 +17,7 @@
       },
       "rule": {
         "link": "https://azure.github.io/Azure-Proactive-Resiliency-Library/services/networking/load-balancer/#lb-1---use-standard-load-balancer-sku",
-        "name": "azurerm_lb.sku_must_be_[Standard]",
+        "name": "simple_value_azurerm_lb.sku",
         "severity": "error"
       }
     }

integration/unknownrule-null-incorrect/result.json

@@ -17,7 +17,7 @@
       },
       "rule": {
         "link": "https://azure.github.io/Azure-Proactive-Resiliency-Library/services/compute/virtual-machines/#vm-2---deploy-vms-across-availability-zones",
-        "name": "azurerm_virtual_machine.zone_must_be_unknown",
+        "name": "unknown_value_azurerm_virtual_machine.zone",
         "severity": "error"
       }
     }