Skip to content

Fix arm-resource-operation rule to no get trigger for ArmProviderActionAsync and ArmProviderActionSync #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlitzelMendez
Copy link
Member

@AlitzelMendez AlitzelMendez commented Apr 14, 2025

issue: #2081

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 14, 2025

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

Fix the arm-resource-operation rule to exclude ArmProviderActionAsync and ArmProviderActionSync operations, as they are not considered resource operations.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 14, 2025

You can try these changes here

🛝 Playground 🌐 Website

@AlitzelMendez AlitzelMendez marked this pull request as ready for review April 14, 2025 20:02
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - we should have a test PR against typespec-next (public and private) to verify

@AlitzelMendez
Copy link
Member Author

@AlitzelMendez AlitzelMendez added this pull request to the merge queue May 13, 2025
Merged via the queue into Azure:main with commit 4b1bba1 May 13, 2025
22 checks passed
@AlitzelMendez AlitzelMendez deleted the fix-arm-resource-operation-rules branch May 13, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter arm-resource-operation shouldn't be reported on non-resource operation
3 participants