-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
FIX: Fixes energy names being the PTCGL tokens
this commit also adds PAL support the latest set
- Loading branch information
Showing
1 changed file
with
27 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do unit tests need updating?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of missing set abbreviations:
OBF, MEW, SVE, POP1-POP9, PPS1-PPS2, SVE, WP, NP, DPP, HSP, SPP
So we need to support these?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely won't need to support these
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could assign these to an intern?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont have interns
OBF and MEW are upcoming scarlet and violet expansion sets after PAL tho?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh good catch, no wonder I didn't recognize these.. (I'm in NA)
Yes then, we would need to add those for future support
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all things that are in bulbapedia's currently list of english expansion sets
i don't know why there are some that i missed cuz i literally used the same bulbapedia page page in april
so we don't need: SVE, POP1-POP9, PPS1-PPS2, SVE, WP, NP, DPP, HSP, SPP?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we only need anything after SVI, I don't recognize any of those set abbreviations, so I'm assuming they aren't new?
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POP/PPS are POP / Play! Pokemon Prize Packs
SVE is scarlet/violet basic energy set from march this year
The rest are black star promos
wondering if support is needed since we rely on that set list to filter out set names and remove them
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh, in that case we should add it all then.
243e2f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get your intern to do that and the unit tests i guess