Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miconvert_voxel_to_real: Ignore scaling for float volumes #109

Merged
merged 1 commit into from
Jul 17, 2020
Merged

miconvert_voxel_to_real: Ignore scaling for float volumes #109

merged 1 commit into from
Jul 17, 2020

Conversation

cfhammill
Copy link
Contributor

Adds the float check and a test that it works.

@cfhammill
Copy link
Contributor Author

should solve #108

@gdevenyi
Copy link
Contributor

Awesome thanks @cfhammill !

@gdevenyi gdevenyi requested a review from vfonov July 17, 2020 19:00
@cfhammill
Copy link
Contributor Author

No problem, travis failure looks unrelated to this PR.

@gdevenyi
Copy link
Contributor

Tests all pass locally, so it has something to do with the build/build environment on Travis.

@vfonov
Copy link
Member

vfonov commented Jul 17, 2020

looks ok

@vfonov vfonov merged commit ffb5fb2 into BIC-MNI:develop Jul 17, 2020
@bcdarwin bcdarwin mentioned this pull request Jul 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfonov vfonov vfonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfhammill @gdevenyi @vfonov