New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Dashboard: Variable Referencing in Lattice Configuration #829

Open

proy30 wants to merge 12 commits into BLAST-ImpactX:development from proy30:dashboard/variable_inputs_for_lattice_config

Member

proy30 commented Feb 7, 2025

Allows dashboard users to define variable names, assign numeric values, and reference these variables in lattice configurations.

Variable Naming Requirements:

The variable name must begin with an alphabetical character

Variable Value Requirements:

The value must be numeric.

To Do:

Implement core functionality
Resolve UI reactivity issues
- The current nested structure severely affects reactivity.

proy30 added 11 commits

February 6, 2025 22:41


          add variables tab, some ui components, some funcitonality, basic vali…

f7c63fb

…dation


          add validation to require first char of var name as alphabetical letter

48630e5


          do not save var_name if validation fails

4be4c2a


          show 'add_variable' button only on last index

2e2bc5d

doesnt make sense to display the button on all rows if it adds the button in the same location


          restructure vlaidation

0c9d7c6


          add variable reset button


          Restructure the code

c0312c6


          Update docstring and type hints

f285ba8


          add v_model for correct flushing

05c1ef6


          dont run sim if error in variables

7e8179a


          cleaup

feb21f7

proy30 assigned proy30 and unassigned proy30

proy30 added the component: dashboard label


          [pre-commit.ci] auto fixes from pre-commit.com hooks

70ac6b3

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems

View reviewed changes

src/python/impactx/dashboard/Input/latticeConfiguration/helper.py

+                      return duplicates
+                  @staticmethod
+                  def validate_variable_name(new_name, index) -> None:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

src/python/impactx/dashboard/Input/latticeConfiguration/helper.py

+                      duplicate_indexes = LatticeVariableHandler.get_duplicate_indexes(
+                          new_name, index
+                      )
+                      send_error = set_var_error_message("error")

Check warning

Code scanning / CodeQL

Use of the return value of a procedure Warning

The result of

LatticeVariableHandler.validate_variable_name.set_var_error_message

is used even though it is always None.

src/python/impactx/dashboard/Input/latticeConfiguration/helper.py

+                      send_error = set_var_error_message("error")
+                      if not alpha:
+                          send_error

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.

src/python/impactx/dashboard/Input/latticeConfiguration/helper.py

+                          state.dirty("variables")
+                          return True
+                      elif duplicate_indexes:
+                          for index in duplicate_indexes:

Check failure

Code scanning / CodeQL

Suspicious unused loop iteration variable Error

For loop variable 'index' is not used in the loop body.

src/python/impactx/dashboard/Input/latticeConfiguration/helper.py

+                          return True
+                      elif duplicate_indexes:
+                          for index in duplicate_indexes:
+                              send_error

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.

Member Author

proy30 commented Feb 7, 2025

proy30 changed the title ~~[WIP] Dashboard: Variable Referencing in Lattice Configuration~~ [Draft] Dashboard: Variable Referencing in Lattice Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: dashboard