-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3892: Add a link to login page + better handling back-end translations #1956
Open
beygorghor
wants to merge
38
commits into
main
Choose a base branch
from
IA-3892-login-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1b333f
to
0692d0e
Compare
1183c17
to
a407e67
Compare
ce01bf0
to
c686440
Compare
74ed1fe
to
b1fe8cb
Compare
738e0b1
to
b37280f
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add a learn more link on login page (linking to https://www.openiaso.com/).
This link should be customizable and not be displayed if unset.
Also Django translations are not well translated.
As used now in python files to return results to the frontend and not only in templates and text, we should improve the translation process and block CI if a translation is missing.
Related JIRA tickets : IA-3892
Self proofreading checklist
Doc
Changes
settings.py
to avoid errors withLOCALE_PATHS
makemessage
LEARN_MORE_URL
How to test
run
python manage.py make_translations
to generate .po files locally and run checks, it should passrun
python manage.py compile_translations
to compile messageadd LEARN_MORE_URL="https://www.openiaso.com/" to your .env file
go to login page, the link at the bottom should be visible and translated
logo should be clickable
remove the var, no more link or clickable logo
Edit ne of the .po file and delete one translation. Rerun
python manage.py make_translations
, it should failSame is happening on the CI, it's failing with missing translations : https://github.com/BLSQ/iaso/actions/runs/13163991120/job/36739556593
Print screen / video
Notes
Things that the reviewers should know:
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.