-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3953: include opening / closing date on import export #1993
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a bit of automated tests
I tested the feature on staging with the following file: https://drive.google.com/file/d/1ldRL_iVISeKTBevl292yntpXQWzlOJQs/view?usp=sharing and it did not update the opening times after I edited them in QGIS: |
@madewulf this as not been deployed on staging yet, you have to try it locally to make it work, anyway i have added some test on the import and the export features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to extract a GeoPackage and saw the 2 columns.
I was able to import a GeoPackage that didn't have the two columns.
I was able to import a GeoPackage that has the new columns.
I updated the two dates, re-exported the package, and saw my two dates.
to visualize a geopackage without too much work : https://mestachs.github.io/taskr/#/gh/g/mestachs/61ec8c5561ca40630df34fc2a6d92f9a
so when the column is set to null the date in iaso are untouched. UPDATE "level-4-Facility" SET opening_date = NULL; I would change the behavior to something "geopackage" is the "truth" with
|
… orgunit, if column is not there do nothing
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : IA-3953
Self proofreading checklist
Changes
Modify import and export script to take opening and closed date into consideration
How to test
Make sure you have an org unit with a opening and closing date
Generate a gpkg export from the org units page of all the org units
Recreate a new version of the source from the generated gpkg
Open the detail on the org unit on the new version, opening / closing dates should be ok
If a specific config is required explain it here: dataset, account, profile, etc.
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.