Merge pull request #34 from Bandwidth/task/update-machine-detection-name

DX-2243 Update Machine Detection Model Name
Bandwidth · Sep 27, 2021 · 80c2844 · 80c2844
2 parents a66d5b1 + 5b25f98
commit 80c2844
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   deploy:
-    name: Validate SDK 
+    name: Validate SDK
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -24,7 +24,7 @@ jobs:
         USER_NUMBER: ${{ secrets.USER_NUMBER }}
         BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }}
     - uses: Bandwidth/[email protected]
-      if: always()
+      if: failure() && !github.event.pull_request.draft
       with:
         job-status: ${{ job.status }}
         slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}

diff --git a/src/Voice/Models/CreateCallRequest.php b/src/Voice/Models/CreateCallRequest.php
@@ -123,7 +123,7 @@ class CreateCallRequest implements \JsonSerializable
 
     /**
      * @todo Write general description for this property
-     * @var \BandwidthLib\Voice\Models\MachineDetectionRequest|null $machineDetection public property
+     * @var \BandwidthLib\Voice\Models\MachineDetectionConfiguration|null $machineDetection public property
      */
     public $machineDetection;
 

diff --git a/src/Voice/Models/MachineDetectionRequest.php → .../Models/MachineDetectionConfiguration.php b/src/Voice/Models/MachineDetectionRequest.php → .../Models/MachineDetectionConfiguration.php
@@ -10,7 +10,7 @@
 /**
  * @todo Write general description for this model
  */
-class MachineDetectionRequest implements \JsonSerializable
+class MachineDetectionConfiguration implements \JsonSerializable
 {
     /**
      * The machine detection mode. If set to 'async', the detection result will be sent in a

diff --git a/tests/ApiTest.php b/tests/ApiTest.php
@@ -90,7 +90,7 @@ public function testCreateCallAndGetCallState() {
 
     public function testCreateCallWithAmdAndGetCallState() {
         $body = new BandwidthLib\Voice\Models\CreateCallRequest();
-        $machineDetection = new BandwidthLib\Voice\Models\MachineDetectionRequest();
+        $machineDetection = new BandwidthLib\Voice\Models\MachineDetectionConfiguration();
 
         $machineDetection->mode = BandwidthLib\Voice\Models\ModeEnum::ASYNC;
         $machineDetection->detectionTimeout = 5.0;