DRAFT: theme/powerline-naked: harmonize powerline.base files
#2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/powerline-naked
branch
5 times, most recently
from
b7e768f
to
940f571
Compare
gaelicWizard
force-pushed
the
theme/powerline-naked
branch
2 times, most recently
from
aabf1bb
to
3925421
Compare
gaelicWizard
force-pushed
the
theme/powerline-naked
branch
4 times, most recently
from
c5ed9b0
to
9c1cf2b
Compare
- Local some variables,
- install reasonable defaults, based on `theme/powerline-plain` which doens't use the special font,
- Use `\D{fmt}` instead of `$(date +fmt)`.
Alsö:
- Use `\u` instead of `${SHORT_USER:-${USER?}}`.
- Use `if`/`then` properly.
- Lose some whitespace from prompt characters; that's what padding is for.
TODO:
- prompt character prefix/suffix support
- use variables rather than subshells...
gaelicWizard
force-pushed
the
theme/powerline-naked
branch
from
9c1cf2b
to
002b6a7
Compare
My apologies to future `git blame` hunters ♥
gaelicWizard
force-pushed
the
theme/powerline-naked
branch
from
002b6a7
to
cfc0c21
Compare
gaelicWizard
changed the title
powerline.base filespowerline.base files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the functions in
theme/powerline-naked/powerline.baseandtheme/powerline/powerline.baseto match more closely. Alsö, linttheme/powerline-naked.Motivation and Context
By updating them to match more closely, we may be able to eliminate the duplicate file in the future. It may be possible to just extend the main file to handle the use case of the alternative implementations.
How Has This Been Tested?
Since I haven't used the powerline* themes much, this is hard for me to test as I'm not used to what "normal" looks like.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.