-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions: clear and consistent log messages #2063
Open
gaelicWizard
wants to merge
10
commits into
Bash-it:master
Choose a base branch
from
gaelicWizard:lib/completion/components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
completions: clear and consistent log messages #2063
gaelicWizard
wants to merge
10
commits into
Bash-it:master
from
gaelicWizard:lib/completion/components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
lib/completion/components
branch
6 times, most recently
from
January 31, 2022 00:28
c319aa2
to
d119871
Compare
- `_bash-it-completion-helper-necessary()` - `_bash-it-completion-helper-sufficient()`
TODO: `pew` TODO: `source <(flutter bash-completion)` vs `eval $(flutter bash-completion)`...saves a subshell...
gaelicWizard
force-pushed
the
lib/completion/components
branch
from
February 23, 2022 23:54
d119871
to
1c2b0bc
Compare
Howdie! please merge from master and resolve conflicts so we can move it to review :) |
seefood
added
clean up
seems abandoned
rattle the cage, and close if nobody wants to keep it going
waiting-for-response
labels
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clean up
seems abandoned
rattle the cage, and close if nobody wants to keep it going
waiting-for-response
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many plugins/completions/whatever check if their associated command is already installed before loading. Find, fix, and add in/to all the completions to ensure consistency and improve
bash-it doctor
.Since completions are such a focused set of functions, create some helpers to simplify.
Motivation and Context
The
_command_exist()
(et al) functions were all weird due to having logging shoved in sideways, which was neither informative nor used anywhere. This pulls the logging from the utility functions and adds it to the relevant call sites, as well as adding to several other plugins that could use it.In particular, some completions or some plugins may be useless but harmless if their associated command is not installed. I've opted to add logging, but not to force an early short-circuit. For example, I've made improvements to a lot of the completions code recently, but I don't have all the relevant tools installed. I load the completion and can test it out anyway, so I don't want to unnecessarily short-circuit it.
The result of all this should be a more reasonable output when
$BASH_IT_LOG_LEVEL
is set, and frombash-it doctor
, as well as avoid polluting theme variables that check for installed utilities.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.