Fix for cases in the virtualenv plugin where pyenv is present but pyenv virtualenvwrapper isn't #2288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for the whole
pyenv virtualenvwrapper
command when loading virtualenv, instead of checking forpyenv only
Motivation and Context
This is useful if the system has
pyenv
installed but notpyenv virtulenvwrapper
. The previous version just printed outwhich is just the pyenv stderr output.
How Has This Been Tested?
Tested both with and
pyenv virtualenvwrapper
present. In both cases virtualenvwrapper.sh was also present. In poth cases ´ _virtualenvwrapper_version´ returned with the verion value. I renamed the plugins in enabled, to ensure that pyenv gets loaded first during debugging. I don't remember the original loading order, but pyenv must be loaded first so that the plugin would work. Otherwise pyenv prints the following:Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.