Skip to content

fix focus to use default focus to leave the browser's default focus sufficiently contrasted on all interactive elements #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cedric07
Copy link
Contributor

@cedric07 cedric07 commented Jun 18, 2025

Suite à de nombreux retours sur des audits a11y, il vaut mieux garder le focus natif navigateur qui automatiquement va garder son anneau de focus suffisamment contrasté par rapport à la couleur de fond (il faut un contraste de minimum 3:1). Webkit utilise par exemple webkit-focus-ring-color

Le fait d'avoir un currentColor pose souvent des soucis, par exemple dans le cas d'un élément blanc sur fond de couleur, donc le focus n'est pas visible, et il faut penser à apporter des surcharges au cas par cas. et en plus s'assurer que le contraste soit suffisant.

C'est typiquement les soucis qu'on a sur plusieurs projets.

On garde également le focus uniquement sur le lien présent dans un card et non la card complète, ce qui apporte plus de contexte et aussi parfois on a des taxo qui sont cliquables dans les cards et donc le focus n'est pas visible.

On se contente juste de jouer avec l'offset et la taille de l'outline au besoin

…ufficiently contrasted on all interactive elements
Copy link

sourcery-ai bot commented Jun 18, 2025

Reviewer's Guide

This PR strips out manual focus styling across select components, SEO utilities, audio controls, skip links, and global focus rules—opting instead for the browser’s native focus ring to ensure consistent, high-contrast outlines.

Class diagram for removed custom focus styles in SCSS utilities and components

classDiagram
    class m-select-custom {
      /* Focus styles removed: color, border-color, outline, box-shadow */
    }
    class seo-container {
      /* No longer extends focus-seo-container */
    }
    class focus-seo-container {
      /* Removed: outline and outline-offset for :focus-visible */
      /* Removed: outline: none for *:focus */
    }
    class audio {
      /* Removed: outline and outline-offset for :focus */
    }
    class skip-links {
      /* Removed: outline-offset for :focus */
    }
    class global_focus {
      /* outline-offset for :focus-visible changed from .5rem to .2rem */
    }
Loading

File-Level Changes

Change Details Files
Removed custom focus styling from the custom select component
  • Deleted &:focus color and border adjustments
  • Eliminated box-shadow focus rings
  • Removed option outline reset
src/scss/02-tools/_m-select-custom.scss
Discarded the SEO focus placeholder and its extension
  • Removed %focus-seo-container rules
  • Deleted @extend in %seo-container
src/scss/04-utilities/_seo.scss
Eliminated manual focus outlines on audio controls
  • Dropped &:focus outline and outline-offset on media controls
src/scss/06-blocks/core/_audio.scss
Removed custom focus-offset from skip links
  • Deleted &:focus outline-offset override
src/scss/05-components/_skip-links.scss
Adjusted global focus-visible offset to be minimal
  • Changed outline-offset from .5rem to .2rem
src/scss/04-utilities/_focus.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cedric07 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant