Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMF compilation rework #33

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

SMF compilation rework #33

wants to merge 2 commits into from

Conversation

marengohue
Copy link
Collaborator

@marengohue marengohue commented May 14, 2023 •
edited
Loading

THIS PR IS STILL IN PROGRESS

  • All parts of the SMF file are now packaged up through a use of a typed SMFWriter
  • SMFWriter is responsible for setting all of the data chunk offsets and for maintaining coherency between headers
  • Every part of the SMF file now has a class representing it, each responsible for own data validation
  • Unit test coverage on the compilation process
  • Additional documentation about the Spring Map Format and the way it is structured (with BAR-specific details)
  • Overall improvements to code, documentation and modularity

Eugene 'marengohue' Rebedailo added 2 commits May 7, 2023 12:45
@marengohue marengohue changed the title SMF compilation rework. SMF compilation rework May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marengohue