Use constants for Bitcoin Core domains and improve readability #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin passphrase gets set by the gtk dialog then the spaced-repetition trainer is launched
epiccurious
force-pushed
the
73-dont-hardcode-urls-epic
branch
from
2e2a4a5 to
a4a441c
Compare
|
Passed my manual testing. Due to rebasing against master, shellcheck is now being enforced. Will address lint issues then re-test. |
* fix: exclude double-quoted variables rule * refactor: fix lint issues in persistent-setup * refactor: increase indentation of onlynet_onion * refactor: satisfy shellcheck SC2181 This refactor doesn't make a ton of sense so another option is to revert this commit and exclude SC2181. * refactor: fix indentation of link_dotfiles subshell * refactor: avoid for loops over find output [SC2044] * refactor: comment out unused variable * refactor: ensure variable never expands to /bin or /lib * refactor: use -n instead of ! -z * Ignore SC2046 in CI checks * fix syntax in yaml * refactor: read without -r will mangle backslashes * refactor: Declare and assign separately to avoid masking return values * refactor: read without -r will mangle backslashes * refactor: Don't use variables in the printf format string * refactor: $ is unnecessary on arithmetic variables * Remove the repeated ', providing ... privacy.' * Clarify that Bitcoin Core connects, not Bails * Make consistent with Lines 113 and 156 * Exclude SC2012 (Use 'cd ... || exit') and SC2164 (find instead of ls) * wording change in comment * lint fixes --------- Co-authored-by: Ben Westgate <[email protected]>
|
Rebased and resolved conflicts. |
epiccurious
changed the title
|
Fixed lint issues. Need to retest and resolve open review comments. |
BenWestgate
requested changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.