Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto.md #2

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

mdavidsaver
Copy link
Collaborator

Fix markdown formatting and describe alternate 0x4000 ROM location.

@mdavidsaver mdavidsaver self-assigned this Apr 2, 2024
@mdavidsaver
Copy link
Collaborator Author

@ldoolitt Based on reading the following, I think the description added is accurate.

// N.B: Newer devices have a relocated ROM at address 0x4000. On these,
// 2K aperture at 0x800 is guaranteed to be 0x0 and not decode to a
// valid ROM. Thus, we first attempt to parse the ROM at the original
// 0x800 location and move on to 0x4000 if unsuccessful.

jrom16_info.name = "ROM 16K";
jrom16_info.description = "Static configuration";
jrom16_info.base_addr = 0x4000;
jrom16_info.addr_width = 14; // 16384 words
jrom16_info.data_width = 16;
jrom16_info.readable = true;

@ldoolitt
Copy link
Contributor

ldoolitt commented Sep 4, 2024

Based on reading the following, I think the description added is accurate.

If that's a question for me, yes, that description is accurate.

@mdavidsaver
Copy link
Collaborator Author

If that's a question for me

@ldoolitt Yes it is. (or any similarly knowledgeable person)

, yes, that description is accurate.

Thank you.

@mdavidsaver mdavidsaver merged commit 8df9cbc into BerkeleyLab:master Sep 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants