Skip to content

fix an issue with tailwindcss #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ImBada
Copy link

@ImBada ImBada commented May 26, 2025

fix an issue #13

@GenieTim
Copy link
Contributor

Thank you for your contribution.

If I remember correctly, with this change, the computation will not work correctly anymore, because the border heights will simultaneously count towards one and the other row height. Use the requireBorderCollapse property instead, since that switches the way the computation works, see here.

Feel free to suggest a change in the documentation if you agree and think that it was not yet documented properly.

On a side note, I would have recommended to simply override this styling in your own stylesheet (you can e.g. add a class to the table and refer to it that way), rather than requiring every user of this library to have that styling, it's not like everyone is using tailwindcss.

@ImBada
Copy link
Author

ImBada commented May 27, 2025

In my case, toggling requireBorderCollapse didn’t work well, so I analyzed each affecting style declaration and realized that fixing this improves the situation. This might only apply when using Tailwind CSS.

I will look for a better solution!

@GenieTim
Copy link
Contributor

I will look for a better solution!

You get this solution also e.g. using

<VirtualTable className={myClass} 

<!-- some other code -->

<style>
.myClass {
border-collapse: initial !important;
}
</style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants