Edit member - don't allow changing user email/id - just role #10406
+73
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable editing email and userid - make email and userid read only when editing member - allow updating role - user_email should not be null in the response - add role in the /member_update response - add backend test to verify if the role is updated
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
is the change on the backend, that the user can be updated by user_email? |
|
At first it looks like only a frontend change, but we do send Changes made on frontend - Disable the input fields for email id and user id. Changes made on backend - Since we're only going to focus on editing member's
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit member - don't allow changing user email/id - just role
This PR enhances the team member update functionality in the
/team/member_updateendpoint. Key improvements include stricter controls around identity fields and expanded support for role management.Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see details-> I have added test in the existing tests/test_team.py
make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Type
🐛 Bug Fix
✅ Test
Changes
user_idanduser_emailread-only during member updates. User must be able to update only therole.user_emailis always included in the response for consistency./team/member_updateresponse to reflect updated values.