Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: fix reuse after release #1479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Feb 2, 2025

Allow an IP to be re-used by the same device after the device has sent a release request

Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit f32b8cb
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/67abd00c40a227000899ed4f

Copy link

codecov bot commented Feb 2, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (d4e6a43) to head (f32b8cb).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dhcp/ipam_internal.go 50.00% 3 Missing and 1 partial ⚠️
pkg/roles/dhcp/dhcp_handler4_release.go 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   70.91%   70.90%   -0.01%     
==========================================
  Files         125      125              
  Lines        7800     7813      +13     
==========================================
+ Hits         5531     5540       +9     
- Misses       1773     1775       +2     
- Partials      496      498       +2     
Flag Coverage Δ
e2e 42.91% <0.00%> (-0.05%) ⬇️
unittest 60.50% <53.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the dhcp/fix-reuse-after-release branch from 6052834 to f32b8cb Compare February 11, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant