-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL-based paging everywhere, and various other changes #16
Open
FlorentLM
wants to merge
56
commits into
BinaryBrain:main
Choose a base branch
from
FlorentLM:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just realised the XML version is completely borked haha |
# Conflicts: # beetsplug/beetstream/artists.py
Oooookay I think we're good to go now - XML version seems to be fine in all the endpoints I could test (using Subtracks on Android). I merged the dev branch into main so it also includes more stuff:
I realise this all became a lot of commits for yous to check though, sorry about that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As disussed in this issue, here's the PR that implements SQL-based paging.
However it also includes pretty heavy rewrites of the response-construction logic (and thus, of all endpoints functions), along with other minor additions / changes.
Full list (I think?):
m3u
format including Beet'splaylist
andsmartplaylist
plugins' playlists (as well as Beetstream's ownplaylist_dir
option of course)ffmpeg
if the user donesn't have the python module installedgetAlbumInfo
andgetAlbumInfo2
endpointsid
, etc) and for consistencyTested with the following clients:
Gonna start implementing support for authentication in another branch and then will add the missing endpoints :)
Cheers!