Skip to content

fix(sdk-core): skip message whitelist check #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

evanzbitgo
Copy link
Contributor

@evanzbitgo evanzbitgo commented Aug 8, 2025

This PR adds coin specific raw message validation directly into the message builder process, removing the need for redundant explicit checks. The ADA midnight drop message validation is now handled within the ADA module.

SC-2681

@ppongbitgo ppongbitgo force-pushed the SC-2419 branch 3 times, most recently from 2bdd58b to e74eaaf Compare August 9, 2025 01:29
@bhavidhingra bhavidhingra changed the title fix(sdk-core): coins specific message sign validate fix(sdk-core): skip message whitelist check Aug 9, 2025
@evanzbitgo evanzbitgo marked this pull request as ready for review August 9, 2025 18:52
@evanzbitgo evanzbitgo requested review from a team as code owners August 9, 2025 18:52
@evanzbitgo
Copy link
Contributor Author

evanzbitgo commented Aug 9, 2025

node 22 test failed due to insufficient test coverage of the module which is not relevant to this change

The job is failing during the unit tests for @bitgo/sdk-core, specifically in the files:

tfiatsgd.ts
tfiatusd.ts
tsusd.ts
The log output shows 0 passing tests out of 40 attempted in each file, with lines 9-17 involved. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant