-
Notifications
You must be signed in to change notification settings - Fork 4
BL-1089-bd-implement-a-profiles-controller #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ed Profiles Repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your ProfilesController class you may want to consider adding some exception handling if you get bad request data from the frontend. Otherwise I think this is a good start.
import java.util.Optional; | ||
|
||
@RestController | ||
@RequestMapping("/profile/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super minor, but I don't think you need the extra '/' at the end of "/profile" in the RequestMapping annotation.
src/main/java/com/bloomtechlabs/coderheroesbea/controllers/ProfilesController.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me!
6152b25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes that you made look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Pedro, you did great work on this and I agree with Tyler's suggestions. |
Will look at this PR tomorrow and assign points. |
…ed Profiles Repository
Description
Create a ProfilesController class with CRUD implementation and created ProfilesService Class and updated the ProfilesRepository Interface.
Fixes # (issue)
Loom Video
(Video Link)
Type of change
Please delete options that are not relevant.
Checklist: